linux-kernel - Re: [PATCH] watchdog: ts4800: release syscon device node in ts4800_wdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5817b7ed-1480-6499-9074-58c47f29221f@roeck-us.net>
Date:   Sat, 13 Oct 2018 21:08:22 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Alexey Khoroshilov <khoroshilov@...ras.ru>,
        Damien Riegel <damien.riegel@...oirfairelinux.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        ldv-project@...uxtesting.org
Subject: Re: [PATCH] watchdog: ts4800: release syscon device node in
 ts4800_wdt_probe()

On 10/13/2018 01:51 PM, Alexey Khoroshilov wrote:
> Put syscon device node when it is not needed anymore.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/ts4800_wdt.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/ts4800_wdt.c b/drivers/watchdog/ts4800_wdt.c
> index 2b8de8602b67..89843b16b04a 100644
> --- a/drivers/watchdog/ts4800_wdt.c
> +++ b/drivers/watchdog/ts4800_wdt.c
> @@ -135,6 +135,7 @@ static int ts4800_wdt_probe(struct platform_device *pdev)
>   	/* set regmap and offset to know where to write */
>   	wdt->feed_offset = reg;
>   	wdt->regmap = syscon_node_to_regmap(syscon_np);
> +	of_node_put(syscon_np);
>   	if (IS_ERR(wdt->regmap)) {
>   		dev_err(&pdev->dev, "cannot get parent's regmap\n");
>   		return PTR_ERR(wdt->regmap);
>