linux-kernel - Re: [PATCH 3.16 232/366] tracing: Deletion of an unnecessary check before iput()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b4c97ade076d0ea6b4c2adde7535a5b48f0c5bc.camel@perches.com>
Date:   Sun, 14 Oct 2018 10:24:18 -0700
From:   Joe Perches <joe@...ches.com>
To:     Ben Hutchings <ben@...adent.org.uk>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Cc:     akpm@...ux-foundation.org,
        Markus Elfring <elfring@...rs.sourceforge.net>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 3.16 232/366] tracing: Deletion of an unnecessary check
 before iput()

On Sun, 2018-10-14 at 16:25 +0100, Ben Hutchings wrote:
> 3.16.60-rc1 review patch.  If anyone has any objections, please let me know.

I believe that no stable or backport kernel needs to
apply patches like this unless it's needed for other
real patches to be applied more easily.

> ------------------
> 
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> 
> commit 16a8ef2751801346f1f76a18685b2beb63cd170f upstream.
> 
> The iput() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Link: http://lkml.kernel.org/r/5468F875.7080907@users.sourceforge.net
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> ---
>  kernel/trace/trace_uprobe.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -552,8 +552,7 @@ error:
>  	return ret;
>  
>  fail_address_parse:
> -	if (inode)
> -		iput(inode);
> +	iput(inode);
>  
>  	pr_info("Failed to parse address or file.\n");
>  
>