linux-kernel - Re: [PATCH v2] x86: Use assembly instruction mnemonics instead of .byte streams in arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181014203022.GF7667@zn.tnic>
Date:   Sun, 14 Oct 2018 22:30:22 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Uros Bizjak <ubizjak@...il.com>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] x86: Use assembly instruction mnemonics instead of
 .byte streams in arch_hweight.h

On Sun, Oct 14, 2018 at 10:23:54PM +0200, Uros Bizjak wrote:
> Recently the minimum required version of binutils was changed to 2.20,
> which supports popcnt instruction mnemonics. The patch removes
> corresponding #defines that implement popcnt instructions using target-dependant
> .byte streams and uses unified instruction mnemonics instead.
> 
> Tested by building x86_64 and i386 version of the kernel and comparing
> objdump dumps of the pathced and unpatched vmlinux.o. They were the same.
> 
> v2: Update commit message to emphasize removal of #defines.
> 
> Signed-off-by: Uros Bizjak <ubizjak@...il.com>
> ---
>  arch/x86/include/asm/arch_hweight.h | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)

Thanks.

But with one week before the merge window and this being not nearly
urgent, it'll have to wait for after the merge window.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.