linux-kernel - Re: [PATCH V12 0/8] C-SKY(csky) Linux Kernel Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 14 Oct 2018 22:38:36 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Guo Ren <ren_guo@...ky.com>
Cc:     tglx@...utronix.de, jason@...edaemon.net, marc.zyngier@....com,
        robh+dt@...nel.org, mark.rutland@....com, will.deacon@....com,
        jhogan@...nel.org, paul.burton@...s.com, peterz@...radead.org,
        arnd@...db.de, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH V12 0/8] C-SKY(csky) Linux Kernel Driver

On 14/10/2018 18:26, Guo Ren wrote:
> Hi Daniel,
> 
> Thx for reply and review.
> 
> On Sat, Oct 13, 2018 at 10:50:34PM +0200, Daniel Lezcano wrote:
>> On 12/10/2018 14:02, Guo Ren wrote:
>>> This is about 12th patchset for C-SKY linux drivers and it should pair
>>> with 8th kernel patchset.
>>
>> Guo,
>>
>> I'm willing to take your timer related patches but you have to put a
>> proper description.
> 
> Ok, I've improved all my comment for the drivers. Here is my modification:

Thanks Guo,

the descriptions look ok for the timer part. Can you resend the DT
bindings + timers patches separately with the commit log updated ?

When you add the Changelog you have to insert it *after* the first
'---', so when the patch is git applied, the change log will be
discarded and won't appear in git.

eg.

commit 6b465856936cb8f7eda31b20eb59fb5c8a19d468
Author: Guo Ren <ren_guo@...ky.com>
Date:   Tue Oct 2 16:43:18 2018 +0800

clocksource: add gx6605s SOC system timer

The driver is for gx6605s SOC system timer and there are two
same timers in gx6605s. We use one for clkevt and another one for
clksrc.

The timer is mmio map to access, so we need give mmio address in dts.
The counter at 0x0  offset is clock event. The counter at 0x40 offset is
clock source.

Signed-off-by: Guo Ren <ren_guo@...ky.com>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
---
Changelog:
     - pass checkpatch.pl
     - Add COMIPLE_TEST in Kconfig
     - no cast is needed for "struct clock_event_device *ce = dev"
     - remove: extra space after (u64)
     - Add License and Copyright
     - Use timer-of framework
     - Change name with upstream feedback
     - Use clksource_mmio framework
---


Thanks

  -- Daniel




-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog