lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181014221325.GA26685@avx2>
Date:   Mon, 15 Oct 2018 01:13:25 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     christian@...uner.io
Cc:     linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk
Subject: Re: [PATCH 1/2] sysctl: add overflow detection to proc_get_long()

> > Yecchh...  First of all, the cast back to unsigned long long is completely
> > pointless.  What's more,
> 
> Sorry, seriously asking: why?

In C everything is casted to the same type before doing an operation,
in this case comparison

> This was meant to handle the case where
> sizeof(unsigned long long) != sizeof(unsigned long) and I just looked at
> _kstrtoul() which does the same:

Second cast is unnecessary. I don't remember why I did 2 casts.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ