linux-kernel - Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOLK0pzHAc1ipDbd3Trg2W_Gb_DxdEKM2ML5Fk09u0-O8y6UAg@mail.gmail.com>
Date:   Sun, 14 Oct 2018 21:21:23 +0800
From:   Tianyu Lan <lantianyu1986@...il.com>
To:     linux@...linux.org.uk
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-mips@...ux-mips.org,
        linux@...linux.org, kvm <kvm@...r.kernel.org>,
        Radim Krcmar <rkrcmar@...hat.com>, benh@...nel.crashing.org,
        will.deacon@....com, christoffer.dall@....com, paulus@...abs.org,
        "H. Peter Anvin" <hpa@...or.com>, kys@...rosoft.com,
        kvmarm@...ts.cs.columbia.edu, sthemmin@...rosoft.com,
        mpe@...erman.id.au, "the arch/x86 maintainers" <x86@...nel.org>,
        michael.h.kelley@...rosoft.com, Ingo Molnar <mingo@...hat.com>,
        catalin.marinas@....com, jhogan@...nel.org,
        Tianyu Lan <Tianyu.Lan@...rosoft.com>, marc.zyngier@....com,
        haiyangz@...rosoft.com, kvm-ppc@...r.kernel.org,
        liran.alon@...cle.com, Paolo Bonzini <pbonzini@...hat.com>,
        linux-arm-kernel@...ts.infradead.org,
        "linux-kernel@...r kernel org" <linux-kernel@...r.kernel.org>,
        ralf@...ux-mips.org, paul.burton@...s.com,
        devel@...uxdriverproject.org, vkuznets@...hat.com,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function

Hi Russell:
              Thanks for your review.

On Sun, Oct 14, 2018 at 5:36 PM Russell King - ARM Linux
<linux@...linux.org.uk> wrote:
>
> On Sun, Oct 14, 2018 at 10:27:34AM +0100, Russell King - ARM Linux wrote:
> > On Sun, Oct 14, 2018 at 10:16:56AM +0200, Thomas Gleixner wrote:
> > > On Sun, 14 Oct 2018, Liran Alon wrote:
> > > > > On 13 Oct 2018, at 17:53, lantianyu1986@...il.com wrote:
> > > > >
> > > > > From: Lan Tianyu <Tianyu.Lan@...rosoft.com>
> > > > >
> > > > > This patch is to add wrapper functions for tlb_remote_flush_with_range
> > > > > callback.
> > > > >
> > > > > Signed-off-by: Lan Tianyu <Tianyu.Lan@...rosoft.com>
> > > > > ---
> > > > > Change sicne V3:
> > > > >       Remove code of updating "tlbs_dirty"
> > > > > Change since V2:
> > > > >       Fix comment in the kvm_flush_remote_tlbs_with_range()
> > > > > ---
> > > > > arch/x86/kvm/mmu.c | 40 ++++++++++++++++++++++++++++++++++++++++
> > > > > 1 file changed, 40 insertions(+)
> > > > >
> > > > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> > > > > index c73d9f650de7..ff656d85903a 100644
> > > > > --- a/arch/x86/kvm/mmu.c
> > > > > +++ b/arch/x86/kvm/mmu.c
> > > > > @@ -264,6 +264,46 @@ static void mmu_spte_set(u64 *sptep, u64 spte);
> > > > > static union kvm_mmu_page_role
> > > > > kvm_mmu_calc_root_page_role(struct kvm_vcpu *vcpu);
> > > > >
> > > > > +
> > > > > +static inline bool kvm_available_flush_tlb_with_range(void)
> > > > > +{
> > > > > +       return kvm_x86_ops->tlb_remote_flush_with_range;
> > > > > +}
> > > >
> > > > Seems that kvm_available_flush_tlb_with_range() is not used in this patch…
> > >
> > > What's wrong with that?
> > >
> > > It provides the implementation and later patches make use of it. It's a
> > > sensible way to split patches into small, self contained entities.
> >
> > From what I can see of the patches that follow _this_ patch in the
> > series, this function remains unused.  So, not only is it not used
> > in this patch, it's not used in this series.
>
> Note - I seem to have only received patches 1 through 4, so this is
> based on the patches I've received.
>

Sorry to confuse your. I get from CCers from get_maintainer.pl script.
The next patch "[PATCH V4 3/15]KVM: Replace old tlb flush function with
new one to flush a specified range" calls new function.
https://lkml.org/lkml/2018/10/13/254

The patch "[PATCH V4 4/15] KVM: Make kvm_set_spte_hva() return int"
changes under ARM directory. Please have a look. Thanks.
-- 
Best regards
Tianyu Lan