[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4517632.a0TFakfgol@daneel.sf-tec.de>
Date: Mon, 15 Oct 2018 07:16:59 +0200
From: Rolf Eike Beer <eike-kernel@...tec.de>
To: Firoz Khan <firoz.khan@...aro.org>
Cc: linux-parisc@...r.kernel.org,
"James E . J . Bottomley" <jejb@...isc-linux.org>,
Helge Deller <deller@....de>,
Thomas Gleixner <tglx@...utronix.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Philippe Ombredanne <pombredanne@...b.com>,
Kate Stewart <kstewart@...uxfoundation.org>,
y2038 Mailman List <y2038@...ts.linaro.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux-Arch <linux-arch@...r.kernel.org>,
Arnd Bergmann <arnd@...db.de>,
Deepa Dinamani <deepa.kernel@...il.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@...aro.org>,
linux-parisc-owner@...r.kernel.org
Subject: Re: [PATCH v4 3/6] parisc: add system call table generation support
Firoz Khan wrote:
> Hi Rolf,
>
> On Fri, 12 Oct 2018 at 17:37, Rolf Eike Beer <eike-kernel@...tec.de> wrote:
> > Firoz Khan wrote:
> > > +prefix="$4"
> > > +offset="$5"
> > > +
> > > +fileguard=_UAPI_ASM_PARISC_`basename "$out" | sed \
> > > + -e 'y/abcdefghijklmnopqrstuvwxyz/ABCDEFGHIJKLMNOPQRSTUVWXYZ/' \
> > > + -e 's/[^A-Z0-9_]/_/g' -e 's/__/_/g'`
> > > +grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (
> > > + echo "#ifndef ${fileguard}"
> > > + echo "#define ${fileguard}"
> > > + echo ""
> > > +
> > > + nxt=0
> > > + while read nr abi name entry compat ; do
> > > + if [ -z "$offset" ]; then
> > > + echo -e "#define __NR_${prefix}${name}\t$nr"
> >
> > This mixed indentation with both tabs and spaces is a bit messy.
>
> Is this what you suggested?
> - echo -e "#define __NR_${prefix}${name}\t$nr"
> + echo "#define __NR_${prefix}${name} $nr"
No, this was actually only about the script itself. Looks like your editor has
tab-width 8 and indentation 4 or so.
Eike
Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)
Powered by blists - more mailing lists