[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181015055201.GA21295@infradead.org>
Date: Sun, 14 Oct 2018 22:52:01 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Finn Thain <fthain@...egraphics.com.au>
Cc: Christoph Hellwig <hch@...radead.org>,
"James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Michael Schmitz <schmitzmic@...il.com>,
Hannes Reinecke <hare@...e.de>, linux-scsi@...r.kernel.org,
linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged
commands
On Mon, Oct 15, 2018 at 10:13:37AM +1100, Finn Thain wrote:
> On Sun, 14 Oct 2018, Christoph Hellwig wrote:
>
> > > + *p++ = IDENTIFY(lp && (tp->flags & ESP_TGT_DISCONNECT), lun);
> >
> > I think lp should always be non-NULL here.
> >
>
> It's not clear from Documentation/scsi/scsi_mid_low_api.txt, but I guess
> that's true for scanning of targets.
>
> Is it true in general that queuecommand for a device will not occur before
> its slave_alloc and not after its slave_destroy invocation?
Yes.
Powered by blists - more mailing lists