[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK7LNAQxZcBNadLJhfrmxJGj-XJFVaya3Z1eexZp20vRPwrN7A@mail.gmail.com>
Date: Mon, 15 Oct 2018 15:35:41 +0900
From: Masahiro Yamada <yamada.masahiro@...ionext.com>
To: Christoph Hellwig <hch@....de>
Cc: mporter@...nel.crashing.org, alex.bou9@...il.com,
Dominik Brodowski <linux@...inikbrodowski.net>,
Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
linux-pci@...r.kernel.org, linux-scsi <linux-scsi@...r.kernel.org>,
linux-arch <linux-arch@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH 2/8] powerpc: simplify CONFIG_PCI_QSPAN Kconfig magic
On Sun, Oct 14, 2018 at 12:11 AM Christoph Hellwig <hch@....de> wrote:
>
> The way how CONFIG_PCI_QSPAN selects the CONFIG_PCI default is highly
> unusual and gets in the way of moving CONFIG_PCI into
> drivers/pci/Kconfig. Simplify it by just having it depend on
> CONFIG_PCI.
>
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
> arch/powerpc/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index a80669209155..6fa6f92edb7f 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -955,7 +955,6 @@ config PCI
> bool "PCI support" if PPC_PCI_CHOICE
> default y if !40x && !CPM2 && !PPC_8xx && !PPC_83xx \
> && !PPC_85xx && !PPC_86xx && !GAMECUBE_COMMON
> - default PCI_QSPAN if PPC_8xx
> select GENERIC_PCI_IOMAP
> help
> Find out whether your system includes a PCI bus. PCI is the name of
> @@ -971,7 +970,7 @@ config PCI_SYSCALL
>
> config PCI_QSPAN
> bool "QSpan PCI"
> - depends on PPC_8xx
> + depends on PPC_8xx && PCI
> select PPC_I8259
> help
> Say Y here if you have a system based on a Motorola 8xx-series
> --
> 2.19.1
>
'git grep' did not get any other hit.
masahiro@pug:~/ref/linux$ git grep PCI_QSPAN
arch/powerpc/Kconfig: default PCI_QSPAN if PPC_8xx
arch/powerpc/Kconfig:config PCI_QSPAN
With your patch, PCI_QSPAN will become
a dead config option.
How about removing it entirely?
--
Best Regards
Masahiro Yamada
Powered by blists - more mailing lists