linux-kernel - Re: [PATCH v3 2/2] mmc: tmio: remove TMIO_MMC_HAVE_HIGH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Oct 2018 13:32:25 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-mmc@...r.kernel.org, Ulf Hansson <ulf.hansson@...aro.org>,
        linux-renesas-soc@...r.kernel.org,
        Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] mmc: tmio: remove TMIO_MMC_HAVE_HIGH_REG flag

On Mon, Oct 15, 2018 at 12:28:12AM +0200, Wolfram Sang wrote:
> On Wed, Oct 10, 2018 at 12:51:32PM +0900, Masahiro Yamada wrote:
> > TMIO_MMC_HAVE_HIGH_REG is confusing due to its counter-intuitive name.
> > 
> > All the TMIO MMC variants (TMIO MMC, Renesas SDHI, UniPhier SD) actually
> > have high registers. It is just that each of them implements its own
> > registers there. The original IP from Panasonic only defines registers
> > 0x00-0xff in the bus_shift=1 review. The register area above them is
> > platform-dependent.
> > 
> > In fact, TMIO_MMC_HAVE_HIGH_REG is set only by tmio-mmc.c and used to
> > test the accessibility of CTL_SDIO_REGS. Because it is specific to
> > the TMIO MFD variant, the right thing to do is to move such registers
> > to tmio_mmc.c and delete the TMIO_MMC_HAVE_HIGH_REG flag.
> > 
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> 
> Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

Tested on R-Car H3 ES1.0 and ES2.0, M3N, and H2. No regressions. I
pulled the SD card out during transfer to ensure the reset function will
surely be called.

Tested-by: Wolfram Sang <wsa+renesas@...g-engineering.com>


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)