linux-kernel - Re: [PATCH] md/bitmap: use mddev_suspend/resume instead of ->quiesce()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMGffEkBzPEUPveXbJRVT8YsfBNgq1LJwj4Tc1RTqok23bUHjQ@mail.gmail.com>
Date:   Mon, 15 Oct 2018 13:53:31 +0200
From:   Jinpu Wang <jinpu.wang@...fitbricks.com>
To:     Wang Jinpu <xjtuwjp@...il.com>
Cc:     Shaohua Li <shli@...nel.org>, NeilBrown <neilb@...e.com>,
        linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] md/bitmap: use mddev_suspend/resume instead of ->quiesce()

On Mon, Oct 8, 2018 at 5:24 PM Jack Wang <xjtuwjp@...il.com> wrote:
>
> From: Jack Wang <jinpu.wang@...fitbricks.com>
>
> After 9e1cc0a54556 ("md: use mddev_suspend/resume instead of ->quiesce()")
> We still have similar left in bitmap functions.
>
> Replace quiesce() with mddev_suspend/resume.
>
> Also move md_bitmap_create out of mddev_suspend. and move mddev_resume
> after md_bitmap_destroy. as we did in set_bitmap_file.
>
> Signed-off-by: Jack Wang <jinpu.wang@...fitbricks.com>
> Reviewed-by: Gioh Kim <gi-oh.kim@...fitbricks.com>
>
> ---
> v3->v2: Drop the change in md_bitmap_resize, as Shaohua noticed
> mddev_suspend/resume is supposed to be called with reconfig_mutex hold, it's not
> the case here.
> v2->v1: add reviewed-by.

ping?


-- 
Jack Wang
Linux Kernel Developer

ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin

Tel:       +49 30 577 008  042
Fax:      +49 30 577 008 299
Email:    jinpu.wang@...fitbricks.com
URL:      https://www.profitbricks.de

Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Geschäftsführer: Achim Weiss, Matthias Steinberg, Christoph Steffens