linux-kernel - Re: [PATCH] s390/cio: make vfio_ccw_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181015153946.6c9b0e49.cohuck@redhat.com>
Date:   Mon, 15 Oct 2018 15:39:46 +0200
From:   Cornelia Huck <cohuck@...hat.com>
To:     Sebastian Ott <sebott@...ux.ibm.com>
Cc:     Halil Pasic <pasic@...ux.ibm.com>,
        Eric Farman <farman@...ux.ibm.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390/cio: make vfio_ccw_io_region static

On Mon, 15 Oct 2018 13:31:39 +0200 (CEST)
Sebastian Ott <sebott@...ux.ibm.com> wrote:

> Fix the following sparse warning:
> drivers/s390/cio/vfio_ccw_drv.c:25:19: warning: symbol 'vfio_ccw_io_region'
> was not declared. Should it be static?

Hm, it seems my workflow needs more static checkers.

> 
> Signed-off-by: Sebastian Ott <sebott@...ux.ibm.com>
> ---
>  drivers/s390/cio/vfio_ccw_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
> index f47d16b5810b..edbf542d82af 100644
> --- a/drivers/s390/cio/vfio_ccw_drv.c
> +++ b/drivers/s390/cio/vfio_ccw_drv.c
> @@ -22,7 +22,7 @@
>  #include "vfio_ccw_private.h"
>  
>  struct workqueue_struct *vfio_ccw_work_q;
> -struct kmem_cache *vfio_ccw_io_region;
> +static struct kmem_cache *vfio_ccw_io_region;
>  
>  /*
>   * Helpers

Thanks, applied.