linux-kernel - Re: [PATCH] doc: rcu: Fix code listing in performance and scalability requirements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181015173633.GA2674@linux.ibm.com>
Date:   Mon, 15 Oct 2018 10:36:33 -0700
From:   "Paul E. McKenney" <paulmck@...ux.ibm.com>
To:     "Joel Fernandes (Google)" <joel@...lfernandes.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] doc: rcu: Fix code listing in performance and
 scalability requirements

On Sun, Oct 14, 2018 at 07:29:42PM -0700, Joel Fernandes (Google) wrote:
> The code listing under this section has a quick quiz that says line 19
> uses rcu_access_pointer, but the code listing itself does not. Fix this.
> 
> Signed-off-by: Joel Fernandes (Google) <joel@...lfernandes.org>

Good eyes!  Queued for the merge window after this coming one,
thank you!

							Thanx, Paul

> ---
>  .../RCU/Design/Requirements/Requirements.html    |  2 +-
>  kernel/sys.c                                     | 16 ++++++++++++++++
>  2 files changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/RCU/Design/Requirements/Requirements.html b/Documentation/RCU/Design/Requirements/Requirements.html
> index 4fae55056c1d..f74a2233865c 100644
> --- a/Documentation/RCU/Design/Requirements/Requirements.html
> +++ b/Documentation/RCU/Design/Requirements/Requirements.html
> @@ -1596,7 +1596,7 @@ used in place of <tt>synchronize_rcu()</tt> as follows:
>  16   struct foo *p;
>  17
>  18   spin_lock(&amp;gp_lock);
> -19   p = rcu_dereference(gp);
> +19   p = rcu_access_pointer(gp);
>  20   if (!p) {
>  21     spin_unlock(&amp;gp_lock);
>  22     return false;
> -- 
> 2.19.0.605.g01d371f741-goog
>