[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181015183218.GA16900@kroah.com>
Date: Mon, 15 Oct 2018 20:32:18 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc: linux-kernel@...r.kernel.org,
Niklas Cassel <niklas.cassel@...aro.org>
Subject: Re: [PATCH] slimbus: ngd: QCOM_QMI_HELPERS has to be selected
On Wed, Oct 03, 2018 at 06:52:36PM +0100, Srinivas Kandagatla wrote:
> From: Niklas Cassel <niklas.cassel@...aro.org>
>
> QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is
> to select it, not depend upon it.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@...aro.org>
> Reviewed-by: Alex Elder <elder@...aro.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
> drivers/slimbus/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
> index 9d73ad806698..9cca2c3559f2 100644
> --- a/drivers/slimbus/Kconfig
> +++ b/drivers/slimbus/Kconfig
> @@ -22,8 +22,8 @@ config SLIM_QCOM_CTRL
>
> config SLIM_QCOM_NGD_CTRL
> tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
> - depends on QCOM_QMI_HELPERS
> depends on HAS_IOMEM && DMA_ENGINE
> + select QCOM_QMI_HELPERS
> help
> Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device
> Component is programmed using Linux kernel.
> --
> 2.19.0
>
This adds the following build warning when applied:
WARNING: unmet direct dependencies detected for QCOM_QMI_HELPERS
Depends on [n]: ARCH_QCOM && NET [=y]
Selected by [m]:
- SLIM_QCOM_NGD_CTRL [=m] && SLIMBUS [=m] && HAS_IOMEM [=y] && DMA_ENGINE [=y]
Powered by blists - more mailing lists