[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <42YPr06vs2z9sjF@ozlabs.org>
Date: Mon, 15 Oct 2018 15:01:04 +1100 (AEDT)
From: Michael Ellerman <patch-notifications@...erman.id.au>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Paul Mackerras <paulus@...ba.org>
Cc: Arnd Bergmann <arnd@...db.de>, Geoff Levand <geoff@...radead.org>,
Alistair Popple <alistair@...ple.id.au>,
linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: powerpc: remove redundant 'default n' from Kconfig-s
On Tue, 2018-10-09 at 15:39:46 UTC, Bartlomiej Zolnierkiewicz wrote:
> 'default n' is the default value for any bool or tristate Kconfig
> setting so there is no need to write it explicitly.
>
> Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> is not set' for visible symbols") the Kconfig behavior is the same
> regardless of 'default n' being present or not:
>
> ...
> One side effect of (and the main motivation for) this change is making
> the following two definitions behave exactly the same:
>
> config FOO
> bool
>
> config FOO
> bool
> default n
>
> With this change, neither of these will generate a
> '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
> That might make it clearer to people that a bare 'default n' is
> redundant.
> ...
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/719736e1cc12b2fc28eba2122893a4
cheers
Powered by blists - more mailing lists