linux-kernel - Re: [PATCH v3] staging: gasket: Fix sparse "incorrect type in assignment" warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 15 Oct 2018 11:42:21 -0700
From:   Todd Poynor <toddpoynor@...gle.com>
To:     laurence.rochfort@...il.com
Cc:     Rob Springer <rspringer@...gle.com>, benchan@...omium.org,
        Greg KH <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] staging: gasket: Fix sparse "incorrect type in
 assignment" warnings.

On Wed, Oct 10, 2018 at 2:14 PM Laurence Rochfort
<laurence.rochfort@...il.com> wrote:
>
> Remove the coherent buffer __iomem cookie because the buffer is
> allocated from dma_alloc_coherent().
>
> warning: incorrect type in assignment (different address spaces)
>    expected unsigned char [noderef] [usertype] <asn:2>*virt_base
>    got void *[assigned] mem
> warning: incorrect type in argument 3 (different address spaces)
>    expected void *cpu_addr
>    got unsigned char [noderef] [usertype] <asn:2>*virt_base
>
> Signed-off-by: Laurence Rochfort <laurence.rochfort@...il.com>
> ---
> Changes in v3:
>  - Just remove the __iommem cookie, don't alter type.
>
>  drivers/staging/gasket/gasket_core.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gasket/gasket_core.h b/drivers/staging/gasket/gasket_core.h
> index 275fd0b..e62adcd 100644
> --- a/drivers/staging/gasket/gasket_core.h
> +++ b/drivers/staging/gasket/gasket_core.h
> @@ -231,7 +231,7 @@ struct gasket_coherent_buffer_desc {
>  /* Coherent buffer structure. */
>  struct gasket_coherent_buffer {
>         /* Virtual base address. */
> -       u8 __iomem *virt_base;
> +       u8 *virt_base;
>
>         /* Physical base address. */
>         ulong phys_base;
> --
> 2.9.5

Reviewed-by: Todd Poynor <toddpoynor@...gle.com>

Thanks!