[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOGAQeqiWMseXPi6n2gkBHAWhsRdwDyMXpCFB1h2mEuQLJz-mw@mail.gmail.com>
Date: Mon, 15 Oct 2018 15:04:47 -0700
From: Roman Kiryanov <rkir@...gle.com>
To: gregkh@...uxfoundation.org
Cc: linux-kernel@...r.kernel.org, Todd Kjos <tkjos@...gle.com>
Subject: Re: [PATCH v3 07/15] platform: goldfish: pipe: Return status from
"deinit" since "remove" does not do much
> This function can not fail, why are you returning 0 always? That
> doesn't make sense.
remove in struct platform_driver requires returning something, we have
to have "return" somewhere.
I think we want to return closer to the place where we do something useful.
Powered by blists - more mailing lists