linux-kernel - Re: net/wan: hostess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dfa87c53-3b26-4473-5166-180760004f1e@infradead.org>
Date:   Mon, 15 Oct 2018 15:24:28 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Krzysztof Hałasa <khalasa@...p.pl>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Alan Cox <gnomes@...rguk.ukuu.org.uk>
Subject: Re: net/wan: hostess_sv11 + z85230 problems

On 10/15/18 1:20 AM, Krzysztof Hałasa wrote:
> Hi,
> 
> Randy Dunlap <rdunlap@...radead.org> writes:
> 
>> kernel 4.19-rc7, on i386, with NO wan/hdlc/hostess/z85230 hardware:
>>
>> modprobe hostess_sv11 + autoload of z85230 give:
> 
> BTW Hostess SV11 is apparently an ISA card, with all those problems.

Yeah.

>> [ 3162.511877] Call Trace:
...
> 
> Not sure about z8530 internals (driver and hw), but I guess the sv11
> driver should initialize the hw first, and only then request_irq().
> Perhaps there should be no "default address" either? The user would
> have to provide the hardware parameters explicitly.
> 
> How about this (totally untested):
> Fix the Hostess SV11 driver trying to use the hardware before its
> existence is detected.
> 
> Signed-off-by: Krzysztof Halasa <khalasa@...p.pl>

Tested-by: Randy Dunlap <rdunlap@...radead.org>

or you can just rm it, like Alan suggested.

thanks.
-- 
~Randy