linux-kernel - Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef19e79a-d975-bde4-1692-65389ead7c15@wdc.com>
Date:   Mon, 15 Oct 2018 15:45:46 -0700
From:   Atish Patra <atish.patra@....com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Wesley Terpstra <wesley@...ive.com>
Cc:     palmer@...ive.com, linux-riscv@...ts.infradead.org,
        linux-pwm@...r.kernel.org, linux-gpio@...r.kernel.org,
        linus.walleij@...aro.org, robh+dt@...nel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        mark.rutland@....com, hch@...radead.org
Subject: Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM
 Controller.

On 10/10/18 6:51 AM, Thierry Reding wrote:
> On Tue, Oct 09, 2018 at 11:51:22AM -0700, Atish Patra wrote:
> [...]
>> +- interrupts: one interrupt per PWM channel (currently unused in the driver)
> 
> This should probably say what the interrupt is used for. And once you
> have that, remove the comment about it being unused in the driver. DT
> is OS agnostic, so "driver" is very unspecific and your claim may
> actually be false.
> 
> Thierry
> 
As per my understanding, they are generated by hardware but no usage of 
pwm interrupts as of now.

I am not sure if removing the entire entry is a good idea.
What would be the best way to represent that information ?

May be this ?

+-interrupts: one interrupt per PWM channel. No usage in HiFive 
Unleashed SoC.

Regards,
Atish