[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3089039.JAYFEciPKB@avalon>
Date: Tue, 16 Oct 2018 02:11:28 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc: linux-kernel@...r.kernel.org, kernel@...labora.com,
Andrzej Hajda <a.hajda@...sung.com>,
Daniel Vetter <daniel.vetter@...ll.ch>,
Marek Szyprowski <m.szyprowski@...sung.com>,
Archit Taneja <architt@...eaurora.org>,
zain wang <wzz@...k-chips.com>,
dri-devel@...ts.freedesktop.org, Lin Huang <hl@...k-chips.com>,
Douglas Anderson <dianders@...omium.org>,
David Airlie <airlied@...ux.ie>,
Sean Paul <seanpaul@...omium.org>,
Jeffy Chen <jeffy.chen@...k-chips.com>
Subject: Re: [PATCH] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch
Hi Enric,
Thank you for the patch.
On Saturday, 13 October 2018 14:18:44 EEST Enric Balletbo i Serra wrote:
> This patch avoids that building the bridge/analogix source code with
> smatch triggers complaints about inconsistent indenting.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> ---
>
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index
> d68986cea132..75e2649d7515 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1219,12 +1219,12 @@ static int analogix_dp_bridge_attach(struct
> drm_bridge *bridge) * plat_data->attch return, that's why we record the
> connector
> * point after plat attached.
> */
> - if (dp->plat_data->attach) {
> - ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
> - if (ret) {
> - DRM_ERROR("Failed at platform attch func\n");
> - return ret;
> - }
> + if (dp->plat_data->attach) {
> + ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
> + if (ret) {
> + DRM_ERROR("Failed at platform attch func\n");
> + return ret;
> + }
> }
This looks good to me. While at it, could you s/attch/attach/ ? With that
fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> if (dp->plat_data->panel) {
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists