[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAD=FV=UZhVni2S1utd=-aAJ3V8+-+TV57-FjrwVJB=jc6Ka8QA@mail.gmail.com>
Date: Tue, 16 Oct 2018 13:14:00 -0700
From: Doug Anderson <dianders@...gle.com>
To: msavaliy@...eaurora.org
Cc: alokc@...eaurora.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tty: serial: qcom_geni_serial: Add suspend support to non
console UART
Hi,
On Tue, Oct 16, 2018 at 6:34 AM Mukesh, Savaliya
<msavaliy@...eaurora.org> wrote:
>
> From: Mukesh Kumar Savaliya <msavaliy@...eaurora.org>
>
> UART driver checks for the PM state and denies suspend if state is ACTIVE.
> This makes UART to deny suspend when client keeps port open which is not
> correct. Instead follow framework and obey suspend-resume callbacks.
>
> Signed-off-by: Mukesh Kumar Savaliya <msavaliy@...eaurora.org>
> ---
> drivers/tty/serial/qcom_geni_serial.c | 36 ++++++-----------------------------
> 1 file changed, 6 insertions(+), 30 deletions(-)
Looks like this patch was re-sent about an hour later with a different
subject of ("tty: serial: qcom_geni_serial: Rectify UART suspend
mechanism") at <https://lkml.kernel.org/r/1539699060-3055-1-git-send-email-msavaliy@codeaurora.org>.
The subject of the later patch seems better. I'll do my review there.
-Doug
Powered by blists - more mailing lists