linux-kernel - Re: [PATCH v7] clk: qcom: Add lpass clock controller driver for SDM845

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <153972602440.5275.16863565217890442118@swboyd.mtv.corp.google.com>
Date:   Tue, 16 Oct 2018 14:40:24 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Michael Turquette <mturquette@...libre.com>,
        Taniya Das <tdas@...eaurora.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        Taniya Das <tdas@...eaurora.org>
Subject: Re: [PATCH v7] clk: qcom: Add lpass clock controller driver for SDM845

Quoting Taniya Das (2018-10-09 11:27:59)
> Add support for the lpass clock controller found on SDM845 based devices.
> This would allow lpass peripheral loader drivers to control the clocks to
> bring the subsystem out of reset.
> LPASS clocks present on the global clock controller would be registered
> with the clock framework based on the device tree flag. Also do not gate
> these clocks if they are left unused, as the lpass clocks require the
> global clock controller lpass clocks to be enabled before they are
> accessed. During clk_disable_unused as these dependency cannot be
> maintained accessing these LPASS clocks would result in unclocked access.
> 
> Signed-off-by: Taniya Das <tdas@...eaurora.org>
> ---

I still have open questions about the GCC clks and if they can be left
on all the time or turned on in this clk driver instead. Either way, the
DT binding should specify that this clock controller node uses the ones
provided by GCC. So I'm marking this as 'changes requested' to drop from
my queue.