linux-kernel - Re: [PATCH] staging: iio: ad7280a: Lines should not end with a '('

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <d00fec12b481f17ce6e844d86be56b5f12bdb0b1.camel@perches.com>
Date:   Tue, 16 Oct 2018 16:07:58 -0700
From:   Joe Perches <joe@...ches.com>
To:     Giuliano Belinassi <giuliano.belinassi@...il.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: ad7280a: Lines should not end with a '('
 - style

(There is a linux-usp@...glegroups.com mailing list
that bounces when I reply, so I removed it from the
cc list)

On Tue, 2018-10-16 at 19:48 -0300, Giuliano Belinassi wrote:
> Hello,
>     Thank you for your review :-).
>     Sorry, but I am a newbie on this, and now I am confused about my next
> step. Should I make a v2 based on your changes, or do you want to submit
> your changes?

I wrote that to encourage you to do more than
what checkpatch says.

I just moved code around and reduced duplication.

There are many similar opportunities for code
refactoring in staging.

You could test what I wrote, add a good commit
message with a subject like:

[PATCH V2] staging: iio: ad7280a: Refactor <functionname>

with a commit message that describes the changes and
perhaps shows the object size difference using

$ size <old> <new>

Maybe add a Suggested-by: tag if it pleases you, but
what I did is trivial and I think it's unnecessary.

Are you doing this for a class assignment?