linux-kernel - Re: [PATCH] staging: add nrf24 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f9ef58fa27419258de32c26d3a80c9e086522221.camel@perches.com>
Date:   Mon, 15 Oct 2018 17:06:04 -0700
From:   Joe Perches <joe@...ches.com>
To:     Marcin Ciupak <marcin.s.ciupak@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: add nrf24 driver

On Tue, 2018-10-16 at 01:17 +0200, Marcin Ciupak wrote:
> This patch adds driver for Nordic Semiconductor nRF24L01+ radio module.

[]
> diff --git a/drivers/staging/nrf24/nrf24_hal.c b/drivers/staging/nrf24/nrf24_hal.c

[]
> +static ssize_t nrf24_read_reg(struct spi_device *spi, u8 addr)
> +{
> +	ssize_t ret;
> +
> +	ret = spi_w8r8(spi, addr);
> +
> +	if (ret < 0)
> +		dev_dbg(&spi->dev, "%s: read 0x%X FAILED", __func__, addr);

Please add terminating newlines to all logging formats

		dev_dbg(&spi->dev, "%s: read 0x%X FAILED\n", __func__, addr);

etc...