linux-kernel - Re: [PATCH] net: fix waring in af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181015.221602.1800911512004774943.davem@davemloft.net>
Date:   Mon, 15 Oct 2018 22:16:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kyeongdon.kim@....com
Cc:     ktkhai@...tuozzo.com, viro@...iv.linux.org.uk,
        garsilva@...eddedor.com, jbaron@...mai.com, dvlasenk@...hat.com,
        xiyou.wangcong@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: fix waring in af_unix

From: Kyeongdon Kim <kyeongdon.kim@....com>
Date: Fri, 12 Oct 2018 19:34:14 +0900

> This fixes the "'hash' may be used uninitialized in this function"
> 
> net/unix/af_unix.c:1041:20: warning: 'hash' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   addr->hash = hash ^ sk->sk_type;
>                       ^
> 
> Signed-off-by: Kyeongdon Kim <kyeongdon.kim@....com>

Please put the initialization at the start of unix_mkname() as a similar
situation exists elsewhere in this file, and the compiler will eventually
warn there too.