linux-kernel - Re: [PATCH net] rxrpc: Fix a missing rxrpc_put_peer() in the error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181015.231447.86687598764526168.davem@davemloft.net>
Date:   Mon, 15 Oct 2018 23:14:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dhowells@...hat.com
Cc:     netdev@...r.kernel.org, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix a missing rxrpc_put_peer() in the
 error_report handler

From: David Howells <dhowells@...hat.com>
Date: Mon, 15 Oct 2018 22:37:21 +0100

> Fix a missing call to rxrpc_put_peer() on the main path through the
> rxrpc_error_report() function.  This manifests itself as a ref leak
> whenever an ICMP packet or other error comes in.
> 
> In commit f334430316e7, the hand-off of the ref to a work item was removed
> and was not replaced with a put.
> 
> Fixes: f334430316e7 ("rxrpc: Fix error distribution")
> Signed-off-by: David Howells <dhowells@...hat.com>

Applied.