[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181016063028.GC882@kroah.com>
Date: Tue, 16 Oct 2018 08:30:28 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Roman Kiryanov <rkir@...gle.com>
Cc: linux-kernel@...r.kernel.org, Todd Kjos <tkjos@...gle.com>
Subject: Re: [PATCH v3 07/15] platform: goldfish: pipe: Return status from
"deinit" since "remove" does not do much
On Mon, Oct 15, 2018 at 03:04:47PM -0700, Roman Kiryanov wrote:
> > This function can not fail, why are you returning 0 always? That
> > doesn't make sense.
>
> remove in struct platform_driver requires returning something, we have
> to have "return" somewhere.
But this code always returns 0, you are changing the function return
value to int, but it can not fail. I do not understand the need for
this change at all, sorry.
> I think we want to return closer to the place where we do something useful.
I do not understand this.
greg k-h
Powered by blists - more mailing lists