linux-kernel - Re: [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f60ee2ae-6b19-4a61-6d9c-38acdebd7fbe@embeddedor.com>
Date:   Tue, 16 Oct 2018 10:46:42 +0200
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Quentin Schulz <quentin.schulz@...tlin.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read

Hi,

On 10/9/18 9:28 AM, Quentin Schulz wrote:
> Hi Gustavo,
> 
> On Tue, Oct 09, 2018 at 12:22:33AM +0200, Gustavo A. R. Silva wrote:
>> Currently, there is an out-of-bounds read on array ctrl->phys,
>> once variable i reaches the maximum array size of SERDES_MAX
>> in the for loop.
>>
>> Fix this by changing the condition in the for loop from
>> i <= SERDES_MAX to i < SERDES_MAX.
>>
> 
> Reviewed-by: Quentin Schulz <quentin.schulz@...tlin.com>
> 

Friendly ping. Who can you take this?

Thanks!
--
Gustavo