linux-kernel - Re: [PATCH net-next v2 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e64b93c2-4f25-ee68-ef23-e947f1e84d55@embeddedor.com>
Date:   Tue, 16 Oct 2018 10:49:36 +0200
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Quentin Schulz <quentin.schulz@...tlin.com>
Cc:     linux-kernel@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next v2 2/2] net: phy: mscc: fix memory leak in
 vsc8574_config_pre_init

Hi,

On 10/10/18 10:34 AM, Quentin Schulz wrote:
> Hi Gustavo,
> 
> On Wed, Oct 10, 2018 at 10:31:39AM +0200, Gustavo A. R. Silva wrote:
>> In case memory resources for *fw* were successfully allocated,
>> release them before return.
>>
>> Addresses-Coverity-ID: 1473968 ("Resource leak")
>> Fixes: 00d70d8e0e78 ("net: phy: mscc: add support for VSC8574 PHY")
> 
> Reviewed-by: Quentin Schulz <quentin.schulz@...tlin.com>
> 

Friendly ping. Dave, can you take this?

Thanks!
--
Gustavo