linux-kernel - Re: [PATCH] spi: Make GPIO CSs honour the SPI_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181016090310.GA7449@sirena.org.uk>
Date:   Tue, 16 Oct 2018 10:03:10 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Trent Piepho <tpiepho@...inj.com>
Cc:     "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "phil@...pberrypi.org" <phil@...pberrypi.org>
Subject: Re: [PATCH] spi: Make GPIO CSs honour the SPI_NO_CS flag

On Mon, Oct 15, 2018 at 06:34:18PM +0000, Trent Piepho wrote:

> What about the calls to spi->controller->set_cs() after this? Should a
> driver provided set_cs method be responsible for checking SPI_NO_CS? 
> Or should it not be called in the first place?

This seems like something that should be done entirely in the framework,
no point in every single driver having to open code the same thing.

> I imagine it depends on what set_cs needs to do, which might not be
> solely related to changing the CS line.

It should be.  If something is hanging other work on set_cs() then it's
going to break.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)