linux-kernel - Re: [PATCH v2] cpufreq: dt-platdev: allow RK3399 to have separate tunables per cluster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6240057.8QT59a4nGB@aspire.rjw.lan>
Date:   Tue, 16 Oct 2018 11:08:40 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Heiko Stuebner <heiko@...ech.de>,
        Derek Basehore <dbasehore@...omium.org>,
        Guenter Roeck <groeck@...omium.org>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] cpufreq: dt-platdev: allow RK3399 to have separate tunables per cluster

On Monday, October 8, 2018 7:55:47 AM CEST Viresh Kumar wrote:
> On 05-10-18, 12:00, Dmitry Torokhov wrote:
> > RK3899 has one cluster with 4 small cores, and another one with 2 big
> > cores, with cores in different clusters having different OPPs and thus
> > needing separate set of tunables. Let's enable this via
> > "have_governor_per_policy" platform data.
> > 
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > ---
> > 
> > v2 changes: commit message updated.
> > 
> > Not tested, but we had a patch unconditionally enabling
> > CPUFREQ_HAVE_GOVERNOR_PER_POLICY flag in tree we used to ship devices
> > based on RK3399 platform.
> > 
> >  drivers/cpufreq/cpufreq-dt-platdev.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> > index fe14c57de6ca..040ec0f711f9 100644
> > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > @@ -78,7 +78,10 @@ static const struct of_device_id whitelist[] __initconst = {
> >  	{ .compatible = "rockchip,rk3328", },
> >  	{ .compatible = "rockchip,rk3366", },
> >  	{ .compatible = "rockchip,rk3368", },
> > -	{ .compatible = "rockchip,rk3399", },
> > +	{ .compatible = "rockchip,rk3399",
> > +	  .data = &(struct cpufreq_dt_platform_data)
> > +		{ .have_governor_per_policy = true, },
> > +	},
> >  
> >  	{ .compatible = "st-ericsson,u8500", },
> >  	{ .compatible = "st-ericsson,u8540", },
> 
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

Patch applied, thanks!