linux-kernel - Re: [PATCH] jffs2: free jffs2_sb_info through jffs2_kill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bb38d45-41c7-9f16-bf6b-d21ba6617f1c@huawei.com>
Date:   Tue, 16 Oct 2018 18:26:34 +0800
From:   Hou Tao <houtao1@...wei.com>
To:     Richard Weinberger <richard.weinberger@...il.com>
CC:     "linux-mtd @ lists . infradead . org" <linux-mtd@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        David Woodhouse <dwmw2@...radead.org>, <stable@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Al Viro <viro@...iv.linux.org.uk>,
        Brian Norris <computersforpeace@...il.com>
Subject: Re: [PATCH] jffs2: free jffs2_sb_info through jffs2_kill_sb()



On 2018/10/16 14:41, Richard Weinberger wrote:
> On Tue, Oct 16, 2018 at 7:53 AM Hou Tao <houtao1@...wei.com> wrote:
>>
>> ping ?
>>
>> On 2018/10/6 17:09, Hou Tao wrote:
>>> When an invalid mount option is passed to jffs2, jffs2_parse_options()
>>> will fail and jffs2_sb_info will be freed, but then jffs2_sb_info will
>>> be used (use-after-free) and freeed (double-free) in jffs2_kill_sb().
>>>
>>> Fix it by removing the buggy invocation of kfree() when getting invalid
>>> mount options.
>>>
>>> Cc: stable@...nel.org
>>> Signed-off-by: Hou Tao <houtao1@...wei.com>
>>> ---
>>>  fs/jffs2/super.c | 4 +---
>>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
>>> index 87bdf0f4cba1..902a7dd10e5c 100644
>>> --- a/fs/jffs2/super.c
>>> +++ b/fs/jffs2/super.c
>>> @@ -285,10 +285,8 @@ static int jffs2_fill_super(struct super_block *sb, void *data, int silent)
>>>       sb->s_fs_info = c;
>>>
>>>       ret = jffs2_parse_options(c, data);
>>> -     if (ret) {
>>> -             kfree(c);
>>> +     if (ret)
>>>               return -EINVAL;
>>> -     }
> 
> Reviewed-by: Richard Weinberger <richard@....at>
> 
> We can carry this via the MTD tree.
Thanks for that.

Regards,
Tao