linux-kernel - Re: [PATCH] scsi: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1murewqsz.fsf@oracle.com>
Date:   Mon, 15 Oct 2018 22:47:40 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        Don Brace <don.brace@...rosemi.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        Adaptec OEM Raid Solutions <aacraid@...rosemi.com>,
        Willem Riede <osst@...de.org>,
        Kai Mäkisara 
        <Kai.Makisara@...umbus.fi>, esc.storagedev@...rosemi.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        osst-users@...ts.sourceforge.net
Subject: Re: [PATCH] scsi: mark expected switch fall-throughs


Gustavo,

>> I'm not entirely convinced that all these identified fall through cases
>> are intentional. From a quick glance, some of them look like bugs...
>
> I took a second look at this and, certainly, the one below looks more like a
> bug. The rest seem to be false positives.

Yep.

>>> diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c
>>> index bd6ac6b..8e1c45d 100644
>>> --- a/drivers/scsi/ips.c
>>> +++ b/drivers/scsi/ips.c
>>> @@ -3485,6 +3485,7 @@ ips_send_cmd(ips_ha_t * ha, ips_scb_t * scb)
>>>  
>>>  		case START_STOP:
>>>  			scb->scsi_cmd->result = DID_OK << 16;
>>> +			/* fall through */
>
> If you confirm this is an actual bug, I can send a separate fix.

I believe it is. So please do.

-- 
Martin K. Petersen	Oracle Linux Engineering