linux-kernel - Re: [PATCH] mtd: rawnand: denali: include <linux/bits.h> instead of <linux/bitops.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181016135943.75655316@bbrezillon>
Date:   Tue, 16 Oct 2018 13:59:43 +0200
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-mtd@...ts.infradead.org,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        linux-kernel@...r.kernel.org, Marek Vasut <marek.vasut@...il.com>,
        Brian Norris <computersforpeace@...il.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH] mtd: rawnand: denali: include <linux/bits.h> instead of
 <linux/bitops.h>

On Tue, 16 Oct 2018 13:33:21 +0900
Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:

> The reason of including <linux/bitops.h> here is just for BIT() and
> GENMASK macros.
> 
> Since commit 8bd9cb51daac8 ("locking/atomics, asm-generic: Move some
> macros from <linux/bitops.h> to a new <linux/bits.h> file"),
> <linux/bits.h> is enough for such compile-time macros.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Reviewed-by: Boris Brezillon <boris.brezillon@...tlin.com>

> ---
> 
>  drivers/mtd/nand/raw/denali.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/denali.h b/drivers/mtd/nand/raw/denali.h
> index 57a5498..25c0060 100644
> --- a/drivers/mtd/nand/raw/denali.h
> +++ b/drivers/mtd/nand/raw/denali.h
> @@ -7,7 +7,7 @@
>  #ifndef __DENALI_H__
>  #define __DENALI_H__
>  
> -#include <linux/bitops.h>
> +#include <linux/bits.h>
>  #include <linux/completion.h>
>  #include <linux/mtd/rawnand.h>
>  #include <linux/spinlock_types.h>