linux-kernel - Re: [PATCH v2] kvm:x86 :remove unnecessary recalculate_apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181016124919.3qgn6a4g7y2srd7k@master>
Date:   Tue, 16 Oct 2018 12:49:19 +0000
From:   Wei Yang <richard.weiyang@...il.com>
To:     Peng Hao <peng.hao2@....com.cn>
Cc:     pbonzini@...hat.com, rkrcmar@...hat.com, tglx@...utronix.de,
        x86@...nel.org, hpa@...or.com, mingo@...hat.com,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH v2]  kvm:x86 :remove unnecessary recalculate_apic_map

On Tue, Oct 16, 2018 at 05:12:30PM +0800, Peng Hao wrote:
>In the previous code, the variable sw_apic_disabled influences
>recalculate_apic_map. But in "KVM: x86: simplify kvm_apic_map"
>(commit:3b5a5ffa928a3f875b0d5dd284eeb7c322e1688a),
>the access to sw_apic_disabled in recalculate_apic_map has been
>deleted.

s/sw_apic_disabled/apic_sw_disabled/ ?

>
>Signed-off-by: Peng Hao <peng.hao2@....com.cn>
>---
> arch/x86/kvm/lapic.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
>index 70dcb55..0380e37 100644
>--- a/arch/x86/kvm/lapic.c
>+++ b/arch/x86/kvm/lapic.c
>@@ -246,10 +246,9 @@ static inline void apic_set_spiv(struct kvm_lapic *apic, u32 val)
> 
> 	if (enabled != apic->sw_enabled) {
> 		apic->sw_enabled = enabled;
>-		if (enabled) {
>+		if (enabled)
> 			static_key_slow_dec_deferred(&apic_sw_disabled);
>-			recalculate_apic_map(apic->vcpu->kvm);
>-		} else
>+		else
> 			static_key_slow_inc(&apic_sw_disabled.key);
> 	}
> }
>-- 
>1.8.3.1

-- 
Wei Yang
Help you, Help me