linux-kernel - Re: [PATCH] tools/perf: fix use of alternatives to find JDIR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181016130959.GA6979@krava>
Date:   Tue, 16 Oct 2018 15:09:59 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Jarod Wilson <jarod@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH] tools/perf: fix use of alternatives to find JDIR

On Mon, Sep 10, 2018 at 10:05:46AM +0200, Jiri Olsa wrote:
> On Thu, Sep 06, 2018 at 06:18:12PM -0400, Jarod Wilson wrote:
> > When a build is run from something like a cron job, the user's $PATH is
> > rather minimal, of note, not including /usr/sbin in my own case. Because
> > of that, an automated rpm package build ultimately fails to find
> > libperf-jvmti.so, because somewhere within the build, this happens...
> > 
> > /bin/sh: alternatives: command not found
> > /bin/sh: alternatives: command not found
> > Makefile.config:849: No openjdk development package found, please install
> > JDK package, e.g. openjdk-8-jdk, java-1.8.0-openjdk-devel
> > 
> > ...and while the build continues, libperf-jvmti.so isn't built, and things
> > fall down when rpm tries to find all the %files specified. Exact same
> > system builds everything just fine when the job is launched from a login
> > shell instead of a cron job, since alternatives is in $PATH, so openjdk is
> > actually found.
> > 
> > The test required to get into this section of code actually specifies the
> > full path, as does a block just above it, so let's do that here too.
> > 
> > CC: Peter Zijlstra <peterz@...radead.org>
> > CC: Ingo Molnar <mingo@...hat.com>
> > CC: Arnaldo Carvalho de Melo <acme@...nel.org>
> > CC: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> > CC: Jiri Olsa <jolsa@...hat.com>
> > CC: Namhyung Kim <namhyung@...nel.org>
> > Signed-off-by: Jarod Wilson <jarod@...hat.com>
> 
> Acked-by: Jiri Olsa <jolsa@...hat.com>

Arnaldo,
could you please pull in this one?

thanks,
jirka