linux-kernel - Re: [LINUX PATCHv3 6/9] serial-uartlite: Change logic how console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Oct 2018 22:09:22 +0800
From:   kbuild test robot <lkp@...el.com>
To:     shubhrajyoti.datta@...il.com
Cc:     kbuild-all@...org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        jslaby@...e.com, jacmet@...site.dk,
        Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>,
        Michal Simek <michal.simek@...inx.com>
Subject: Re: [LINUX PATCHv3 6/9] serial-uartlite: Change logic how
 console_port is setup

Hi Shubhrajyoti,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on next-20181016]
[cannot apply to v4.19-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/shubhrajyoti-datta-gmail-com/serial-uartlite-Add-support-for-dynamic-allocation/20181016-210709
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: i386-randconfig-x019-201841 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: the linux-review/shubhrajyoti-datta-gmail-com/serial-uartlite-Add-support-for-dynamic-allocation/20181016-210709 HEAD 7aba44c5f67836025decfe4dc4ab364c1f83f44d builds fine.
      It only hurts bisectibility.

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/ioport.h:13:0,
                    from include/linux/device.h:15,
                    from include/linux/platform_device.h:14,
                    from drivers/tty//serial/uartlite.c:9:
   drivers/tty//serial/uartlite.c: In function 'ulite_assign':
>> drivers/tty//serial/uartlite.c:684:25: error: invalid type argument of '->' (have 'struct uart_driver')
         !(ulite_uart_driver->cons->flags & CON_ENABLED))
                            ^
   include/linux/compiler.h:58:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/tty//serial/uartlite.c:683:2: note: in expansion of macro 'if'
     if (console_port == port &&
     ^~
>> drivers/tty//serial/uartlite.c:684:25: error: invalid type argument of '->' (have 'struct uart_driver')
         !(ulite_uart_driver->cons->flags & CON_ENABLED))
                            ^
   include/linux/compiler.h:58:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
>> drivers/tty//serial/uartlite.c:683:2: note: in expansion of macro 'if'
     if (console_port == port &&
     ^~
>> drivers/tty//serial/uartlite.c:684:25: error: invalid type argument of '->' (have 'struct uart_driver')
         !(ulite_uart_driver->cons->flags & CON_ENABLED))
                            ^
   include/linux/compiler.h:69:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
>> drivers/tty//serial/uartlite.c:683:2: note: in expansion of macro 'if'
     if (console_port == port &&
     ^~

vim +684 drivers/tty//serial/uartlite.c

   671	
   672		/* Register the port */
   673		rc = uart_add_one_port(&ulite_uart_driver, port);
   674		if (rc) {
   675			dev_err(dev, "uart_add_one_port() failed; err=%i\n", rc);
   676			port->mapbase = 0;
   677			dev_set_drvdata(dev, NULL);
   678			return rc;
   679		}
   680	
   681	#ifdef CONFIG_SERIAL_UARTLITE_CONSOLE
   682		/* This is not port which is used for console that's why clean it up */
 > 683		if (console_port == port &&
 > 684		    !(ulite_uart_driver->cons->flags & CON_ENABLED))
   685			console_port = NULL;
   686	#endif
   687	
   688		return 0;
   689	}
   690	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28007 bytes)