linux-kernel - Re: [PATCH] tools/power/cpupower: fix compilation with STATIC=true

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4a4cb4dc-16d7-7f71-eb99-d4b1e7788862@kernel.org>
Date:   Tue, 16 Oct 2018 08:28:47 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Thomas Renninger <trenn@...e.de>,
        Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        rafael@...nel.org, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] tools/power/cpupower: fix compilation with STATIC=true

On 10/16/2018 05:39 AM, Thomas Renninger wrote:
> On Tuesday, October 16, 2018 10:56:26 AM CEST Konstantin Khlebnikov wrote:
>> Rename duplicate sysfs_read_file into cpupower_read_sysfs and fix linking.
>>
>> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
> 
> Acked-by: Thomas Renninger <trenn@...e.de>
> 
> Thanks!
> 
>> -       $(OUTPUT)../lib/cpufreq.o $(OUTPUT)../lib/sysfs.o
>> +       $(OUTPUT)../lib/cpufreq.o $(OUTPUT)../lib/cpupower.o
> 
> I also looked at this and would only have fixed half of it (overseeing above
> old leftover from cpupower lib introduction).
> I guess, this patch from Konstantin is better and the correct solution.
> 

Thank you both. I will get this into 4.20-rc1 or rc2 depending on how timing
works.

I think this applies to stable as well.

thanks,
-- Shuah