[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOMZO5Ck846zd_Xo=9sVK0EAxNLsUsWiC59H2Ms6x8xoD8iwWw@mail.gmail.com>
Date: Tue, 16 Oct 2018 13:03:47 -0300
From: Fabio Estevam <festevam@...il.com>
To: Leonard Crestez <leonard.crestez@....com>
Cc: Shawn Guo <shawnguo@...nel.org>,
Fabio Estevam <fabio.estevam@....com>,
Rob Herring <robh+dt@...nel.org>,
Marek Vasut <marek.vasut@...il.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
Horia Geanta Neag <horia.geanta@....com>,
Franck LENORMAND <franck.lenormand@....com>,
Aymen Sghaier <aymen.sghaier@....com>,
"David S. Miller" <davem@...emloft.net>,
Mark Rutland <mark.rutland@....com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@...r.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@...ts.infradead.org>,
NXP Linux Team <linux-imx@....com>,
Sascha Hauer <kernel@...gutronix.de>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/4] crypto: mxs-dcp - Add support for dcp clk
Hi Leonard,
On Tue, Oct 16, 2018 at 12:58 PM Leonard Crestez
<leonard.crestez@....com> wrote:
> + /* DCP clock is optional, only used on some SOCs */
> + sdcp->dcp_clk = devm_clk_get(dev, "dcp");
> + if (IS_ERR(sdcp->dcp_clk)) {
> + if (sdcp->dcp_clk != ERR_PTR(-ENOENT))
> + return PTR_ERR(sdcp->dcp_clk);
> + sdcp->dcp_clk = NULL;
This dcp_clk assignment to NULL does not seem to be necessary.
> +
> + ret = clk_prepare_enable(sdcp->dcp_clk);
> + if (ret)
> + return ret;
>
> ret = devm_request_irq(dev, dcp_vmi_irq, mxs_dcp_irq, 0,
> "dcp-vmi-irq", sdcp);
> if (ret) {
> dev_err(dev, "Failed to claim DCP VMI IRQ!\n");
In case of subsequent errors you should call
clk_disable_unprepare(sdcp->dcp_clk).
Powered by blists - more mailing lists