linux-kernel - Re: [PATCH] drivers/vfio: Fix an 8-byte alignment issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181017211532.GB9499@localhost.localdomain>
Date:   Wed, 17 Oct 2018 17:15:33 -0400
From:   Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:     Wenwen Wang <wang6495@....edu>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Kangjie Lu <kjlu@....edu>,
        Alex Williamson <alex.williamson@...hat.com>
Subject: Re: [PATCH] drivers/vfio: Fix an 8-byte alignment issue

On Wed, Oct 17, 2018 at 01:18:19PM -0500, Wenwen Wang wrote:
> This patch adds a 4-byte reserved field in the structure
> vfio_eeh_pe_op to make sure that the u64 fields in the structure
> vfio_eeh_pe_err are 8-byte aligned.

Won't this break 32-bit kernels? That is the size of the structure
will now be 4 bytes bigger..
> 
> Signed-off-by: Wenwen Wang <wang6495@....edu>
> ---
>  include/uapi/linux/vfio.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
> index 1aa7b82..3e71ded 100644
> --- a/include/uapi/linux/vfio.h
> +++ b/include/uapi/linux/vfio.h
> @@ -729,6 +729,7 @@ struct vfio_eeh_pe_op {
>  	__u32 argsz;
>  	__u32 flags;
>  	__u32 op;
> +	__u32 __res;
>  	union {
>  		struct vfio_eeh_pe_err err;
>  	};
> -- 
> 2.7.4
>