linux-kernel - Re: [Lkcamp] [PATCH 0/4] Adds -Wshadow=local on KBUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00beb3a2-e68d-4f6c-d69a-8413acc214c4@koikeco.de>
Date:   Wed, 17 Oct 2018 01:45:54 -0300
From:   Helen Koike <helen@...keco.de>
To:     Leonardo Brás <leobras.c@...il.com>,
        lkcamp@...ts.libreplanetbr.org
Cc:     x86@...nel.org, linux-kbuild@...r.kernel.org,
        Matthew Wilcox <willy6545@...il.com>,
        linux-kernel@...r.kernel.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Andy Lutomirski <luto@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [Lkcamp] [PATCH 0/4] Adds -Wshadow=local on KBUILD_HOSTCFLAGS

Hi Leonardo,

Thanks for the patches.

On 10/16/18 9:07 PM, Leonardo Brás wrote:
> This patchset add -Wshadow=local on KBUILD_HOSTCFLAGS and fixes 
> all code that show this warning.
> 
> The third patch was already submitted, but was not merged yet.
> I like to think it's part of this patchset, but if it was 
> already merged, please ignore it.

You can check if it was merged in the maintainers' tree, if it is not
there then it is not merged :)

imho, I would prefer if you submitted it as a v2 with an explanation of
what changed since v1 (e.g. new commits) or even stating that nothing
has changed and you just regrouped it.
Or better, you could also not re-submit it and just point out that this
series depends on a previous commit (with a link to it).

> 
> Leonardo Brás (4):
>   Adds -Wshadow=local on KBUILD_HOSTCFLAGS
>   Renames variable to fix shadow warning.
>   kbuild: Removes unnecessary shadowed local variable and optimize
>     testing.
>   Changes macro usage to avoid shadowing a variable.
> 
>  Makefile                     |  2 +-
>  arch/x86/entry/vdso/vdso2c.h |  4 ++--
>  scripts/asn1_compiler.c      |  7 +++----
>  scripts/mod/file2alias.c     | 14 ++++++++------
>  4 files changed, 14 insertions(+), 13 deletions(-)
> 

I hope this helps.

Regards,
Helen