linux-kernel - Re: [PATCH] tty: serial: qcom_geni_serial: Don't slow all ports just for kgdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a4b57b252c01d312be10ce586be7d7d@codeaurora.org>
Date:   Wed, 17 Oct 2018 13:04:10 +0530
From:   msavaliy@...eaurora.org
To:     Douglas Anderson <dianders@...omium.org>
Cc:     gregkh@...uxfoundation.org, linux-arm-msm@...r.kernel.org,
        alokc@...eaurora.org, mka@...omium.org, evgreen@...omium.org,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        Jiri Slaby <jslaby@...e.com>,
        linux-arm-msm-owner@...r.kernel.org
Subject: Re: [PATCH] tty: serial: qcom_geni_serial: Don't slow all ports just
 for kgdb

On 2018-10-16 02:14, Douglas Anderson wrote:
> If you turn on CONFIG_KGDB then you'll get CONFIG_CONSOLE_POLL
> selected.
> 
> If you have CONFIG_CONSOLE_POLL selected then the GENI serial driver
> was setting RX_BYTES_PW to 1 for _all_ UART ports.
> 
> This doesn't seem like such a good idea.  Let's only set RX_BYTES_PW
> to 1 for the console port.
> 
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
> 
>  drivers/tty/serial/qcom_geni_serial.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
Good finding, Makes sense to keep changes this way for console only 
port.

Reviewed-by: Mukesh Kumar Savaliya <msavaliy@...eaurora.org>