linux-kernel - Re: [PATCH v4 3/3] iio: magnetometer: Add driver support for PNI RM3100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Oct 2018 16:00:02 +0800
From:   Song Qiang <songqiang1304521@...il.com>
To:     Himanshu Jha <himanshujha199640@...il.com>
Cc:     jic23@...nel.org, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net, robh+dt@...nel.org, mark.rutland@....com,
        preid@...ctromag.com.au, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/3] iio: magnetometer: Add driver support for PNI
 RM3100


On 2018/10/12 下午8:53, Himanshu Jha wrote:
> Hi Qiang,
>
> On Fri, Oct 12, 2018 at 04:36:01PM +0800, Song Qiang wrote:
>>
>> On 2018年10月12日 15:35, Song Qiang wrote:
>>> PNI RM3100 is a high resolution, large signal immunity magnetometer,
>>> composed of 3 single sensors and a processing chip with a MagI2C
>>> interface.
>>>
>> ...
>>> +static irqreturn_t rm3100_trigger_handler(int irq, void *p)
>>> +{
>>> +	struct iio_poll_func *pf = p;
>>> +	struct iio_dev *indio_dev = pf->indio_dev;
>>> +	unsigned long scan_mask = *indio_dev->active_scan_mask;
>>> +	unsigned int mask_len = indio_dev->masklength;
>>> +	struct rm3100_data *data = iio_priv(indio_dev);
>>> +	struct regmap *regmap = data->regmap;
>>> +	int ret, i, bit;
>>> +
>>> +	mutex_lock(&data->lock);
>>> +	switch (scan_mask) {
>>> +	case BIT(0) | BIT(1) | BIT(2):
>>> +		ret = regmap_bulk_read(regmap, RM3100_REG_MX2, data->buffer, 9);
>>> +		mutex_unlock(&data->lock);
>>> +		if (ret < 0)
>>> +			goto done;
>>> +	break;
>>> +	case BIT(0) | BIT(1):
>>> +		ret = regmap_bulk_read(regmap, RM3100_REG_MX2, data->buffer, 6);
>>> +		mutex_unlock(&data->lock);
>>> +		if (ret < 0)
>>> +			goto done;
>>> +	break;
>>> +	case BIT(1) | BIT(2):
>>> +		ret = regmap_bulk_read(regmap, RM3100_REG_MY2, data->buffer, 6);
>>> +		mutex_unlock(&data->lock);
>>> +		if (ret < 0)
>>> +			goto done;
>>> +	break;
>> Hi Jonathan,
>>
>> I just noticed that these three breaks are not proper aligned.
> Please send the new version of a patch as a *new* thread and don't
> use `--in-reply-to` flag(if you're using) to chain into older versions
> as whole thread of older discussion comes up and is often not required.
>
> The changelog gives enough info of what's new in the revised series.
>
>
Hi Himanshu,


Thanks for your advise.

I did it because the following instruction tells me to, and I think it's 
also a very quick way of gathering

all scattered messages. Both ways have their own advantages and 
disadvantages I think. :)

<https://kernelnewbies.org/PatchPhilosophy> Section "Updating and 
resending patches".


yours,

Song Qiang