[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181017080923.GC24540@infradead.org>
Date: Wed, 17 Oct 2018 01:09:23 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Finn Thain <fthain@...egraphics.com.au>
Cc: Hannes Reinecke <hare@...e.de>,
"James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Michael Schmitz <schmitzmic@...il.com>,
linux-scsi@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines
On Tue, Oct 16, 2018 at 04:39:07PM +1100, Finn Thain wrote:
>
> Perhaps I've misunderstood your concern here. Is it a problem that
> esp_scsi.ko may or may not export the function, depending on .config?
>
> For example, if esp_scsi.ko came from a build with CONFIG_SUN3X_ESP=y &&
> !CONFIG_SCSI_ZORRO_ESP && !CONFIG_SCSI_MAC_ESP, then it would export no
> esp_send_pio_cmd() symbol.
>
> A dummy function (mentioned above) might then avoid a link error from
> "modprobe zorro_esp" or "modprobe mac_esp" in this scenario. (The modules
> would load but fail to work properly.)
>
> This seems a bit too contrived so I'll post v3 for you to consider.
Please leave the possibly unused exports as-is.
Powered by blists - more mailing lists