[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20181017083349.GC22535@zn.tnic>
Date: Wed, 17 Oct 2018 10:33:49 +0200
From: Borislav Petkov <bp@...en8.de>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc: Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
Boris Ostrovsky <boris.ostrovsky@...cle.com>,
Juergen Gross <jgross@...e.co>, xen-devel@...ts.xenproject.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: remove redundant 'default n' from Kconfig-s
Hi Bart,
On Tue, Oct 16, 2018 at 03:42:16PM +0200, Bartlomiej Zolnierkiewicz wrote:
> 'default n' is the default value for any bool or tristate Kconfig
> setting so there is no need to write it explicitly.
>
> Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> is not set' for visible symbols") the Kconfig behavior is the same
> regardless of 'default n' being present or not:
>
> ...
> One side effect of (and the main motivation for) this change is making
> the following two definitions behave exactly the same:
>
> config FOO
> bool
>
> config FOO
> bool
> default n
>
> With this change, neither of these will generate a
> '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
> That might make it clearer to people that a bare 'default n' is
> redundant.
> ...
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> ---
> arch/x86/Kconfig | 7 -------
> arch/x86/Kconfig.debug | 1 -
> arch/x86/xen/Kconfig | 1 -
> 3 files changed, 9 deletions(-)
looks good, no difference of allmodconfigs before and after.
But that close before the merge window and it not being urgent, I'll
queue it after the merge window.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
Powered by blists - more mailing lists