linux-kernel - RE: [PATCH v2 3/3] thermal: da9062/61: Prevent hardware access during system suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Oct 2018 08:57:05 +0000
From:   Steve Twiss <stwiss.opensource@...semi.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        "Kuninori Morimoto" <kuninori.morimoto.gx@...esas.com>,
        Support Opensource <Support.Opensource@...semi.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>
CC:     "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 3/3] thermal: da9062/61: Prevent hardware access
 during system suspend

Hi Geert,

Many thanks for looking at this.

On 12 October 2018 08:20 Geert Uytterhoeven wrote:

> Subject: [PATCH v2 3/3] thermal: da9062/61: Prevent hardware access during
> system suspend
> 
> The workqueue used for monitoring the hardware may run while the device
> is already suspended.  Fix this by using the freezable system workqueue
> instead, cfr. commit 51e20d0e3a60cf46 ("thermal: Prevent polling from
> happening during system suspend").

My thinking was:  this device is a PMIC and it will power the system. So when
the device is turned off, the S/W will also not be running.

Although my assumption only works if the PMIC device is the primary system
power -- this has always been the case so far. And although I don't have any
evidence this will change, it may become untrue in the future of course.

> Fixes: 608567aac3206ae8 ("thermal: da9062/61: Thermal junction temperature
> monitoring driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> Untested due to lack of hardware.

So, I have not been able to make any time to test this patch yet -- and with
current workloads this might take a bit of time before I get to it.

Regards,
Steve

> v2:
>   - No changes.
> ---
>  drivers/thermal/da9062-thermal.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/da9062-thermal.c b/drivers/thermal/da9062-
> thermal.c
> index dd8dd947b7f0737c..01b0cb9944577851 100644
> --- a/drivers/thermal/da9062-thermal.c
> +++ b/drivers/thermal/da9062-thermal.c
> @@ -106,7 +106,7 @@ static void da9062_thermal_poll_on(struct work_struct
> *work)
>  					   THERMAL_EVENT_UNSPECIFIED);
> 
>  		delay = msecs_to_jiffies(thermal->zone->passive_delay);
> -		schedule_delayed_work(&thermal->work, delay);
> +		queue_delayed_work(system_freezable_wq, &thermal->work,
> delay);
>  		return;
>  	}
> 
> @@ -125,7 +125,7 @@ static irqreturn_t da9062_thermal_irq_handler(int irq,
> void *data)
>  	struct da9062_thermal *thermal = data;
> 
>  	disable_irq_nosync(thermal->irq);
> -	schedule_delayed_work(&thermal->work, 0);
> +	queue_delayed_work(system_freezable_wq, &thermal->work, 0);
> 
>  	return IRQ_HANDLED;
>  }
> --
> 2.17.1