linux-kernel - Re: [PATCH -next] advansys: remove set but not used variable 'srb_tag' in adv_isr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4950b4fe-61b5-e1c3-9d16-7643107857a5@suse.de>
Date:   Wed, 17 Oct 2018 14:49:50 +0200
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     YueHaibing <yuehaibing@...wei.com>, willy@...radead.org,
        hare@...e.com, jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com
Cc:     linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH -next] advansys: remove set but not used variable
 'srb_tag' in adv_isr_callback

On 17/10/18 14:34, YueHaibing wrote:
> drivers/scsi/advansys.c: In function 'adv_isr_callback':
> drivers/scsi/advansys.c:5952:6: warning:
>  variable 'srb_tag' set but not used [-Wunused-but-set-variable]
> 
> It never used since introduction in
> commit 9c17c62aedb0 ("advansys: use shared host tag map for command lookup")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/scsi/advansys.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
> index 44c9619..223ef6f 100644
> --- a/drivers/scsi/advansys.c
> +++ b/drivers/scsi/advansys.c
> @@ -5949,7 +5949,6 @@ static void adv_async_callback(ADV_DVC_VAR *adv_dvc_varp, uchar code)
>  static void adv_isr_callback(ADV_DVC_VAR *adv_dvc_varp, ADV_SCSI_REQ_Q *scsiqp)
>  {
>  	struct asc_board *boardp = adv_dvc_varp->drv_ptr;
> -	u32 srb_tag;
>  	adv_req_t *reqp;
>  	adv_sgblk_t *sgblkp;
>  	struct scsi_cmnd *scp;
> @@ -5965,7 +5964,6 @@ static void adv_isr_callback(ADV_DVC_VAR *adv_dvc_varp, ADV_SCSI_REQ_Q *scsiqp)
>  	 * completed. The adv_req_t structure actually contains the
>  	 * completed ADV_SCSI_REQ_Q structure.
>  	 */
> -	srb_tag = le32_to_cpu(scsiqp->srb_tag);
>  	scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag);

Shouldn't this be:
	scp = scsi_host_find_tag(boardp->shost,
					le32_to_cpu(scsiqp->srb_tag));


-- 
Johannes Thumshirn                                        SUSE Labs
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850