linux-kernel - Re: [PATCH v1 05/11] dt-bindings: regulator: Change regulator-coupled-max-spread property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e9e90a1-0580-cc20-f7f9-69fefae0b3dd@gmail.com>
Date:   Wed, 17 Oct 2018 16:32:01 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Mark Brown <broonie@...nel.org>,
        Maciej Purski <m.purski@...sung.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH v1 05/11] dt-bindings: regulator: Change
 regulator-coupled-max-spread property

On 10/17/18 4:25 PM, Rob Herring wrote:
> On Fri, Oct 05, 2018 at 06:36:32PM +0300, Dmitry Osipenko wrote:
>> Redefine binding for regulator-coupled-max-spread property in a way that
>> max-spread values are defined per regulator couple instead of defining
>> single max-spread for the whole group of coupled regulators.
>>
>> With that change the following regulators coupling configuration will be
>> possible:
>>
>> regA: regulatorA {
>> 	regulator-coupled-with = <&regB &regC>;
>> 	regulator-coupled-max-spread = <100000 300000>;
>> };
>>
>> regB: regulatorB {
>> 	regulator-coupled-with = <&regA &regC>;
>> 	regulator-coupled-max-spread = <100000 200000>;
>> };
>>
>> regC: regulatorC {
>> 	regulator-coupled-with = <&regA &regB>;
>> 	regulator-coupled-max-spread = <300000 200000>;
>> };
>>
>> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
>> ---
>>  Documentation/devicetree/bindings/regulator/regulator.txt | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt
>> index a7cd36877bfe..9b525b657fca 100644
>> --- a/Documentation/devicetree/bindings/regulator/regulator.txt
>> +++ b/Documentation/devicetree/bindings/regulator/regulator.txt
>> @@ -76,8 +76,9 @@ Optional properties:
>>  - regulator-coupled-with: Regulators with which the regulator
>>    is coupled. The linkage is 2-way - all coupled regulators should be linked
>>    with each other. A regulator should not be coupled with its supplier.
>> -- regulator-coupled-max-spread: Max spread between voltages of coupled regulators
>> -  in microvolts.
>> +- regulator-coupled-max-spread: Array of maximum spread between voltages of
>> +  coupled regulators in microvolts, each value in the array relates to the
>> +  corresponding couple specified by the regulator-coupled-with property.
> 
> Is this in use already? How is a single entry handled?

No, it is not in use yet. Only some of the prerequisite patches were applied. 

Initially single entry was supposed to be re-used by all of regulator couples. Now single entry describes a single couple only.