[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <bcfe2e44-4595-2a62-c3f2-16bdad5ed196@amd.com>
Date: Wed, 17 Oct 2018 14:50:45 +0000
From: "Moger, Babu" <Babu.Moger@....com>
To: Fenghua Yu <fenghua.yu@...el.com>
CC: "tglx@...utronix.de" <tglx@...utronix.de>,
"mingo@...hat.com" <mingo@...hat.com>,
"hpa@...or.com" <hpa@...or.com>,
"reinette.chatre@...el.com" <reinette.chatre@...el.com>,
"james.morse@....com" <james.morse@....com>,
"tony.luck@...el.com" <tony.luck@...el.com>,
"corbet@....net" <corbet@....net>,
"x86@...nel.org" <x86@...nel.org>,
"peterz@...radead.org" <peterz@...radead.org>,
"pombredanne@...b.com" <pombredanne@...b.com>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"kstewart@...uxfoundation.org" <kstewart@...uxfoundation.org>,
"bp@...e.de" <bp@...e.de>,
"rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
"ak@...ux.intel.com" <ak@...ux.intel.com>,
"kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
"xiaochen.shen@...el.com" <xiaochen.shen@...el.com>,
"colin.king@...onical.com" <colin.king@...onical.com>,
"Hurwitz, Sherry" <sherry.hurwitz@....com>,
"Lendacky, Thomas" <Thomas.Lendacky@....com>,
"pbonzini@...hat.com" <pbonzini@...hat.com>,
"dwmw@...zon.co.uk" <dwmw@...zon.co.uk>,
"luto@...nel.org" <luto@...nel.org>,
"jroedel@...e.de" <jroedel@...e.de>,
"jannh@...gle.com" <jannh@...gle.com>,
"dima@...sta.com" <dima@...sta.com>,
"jpoimboe@...hat.com" <jpoimboe@...hat.com>,
"vkuznets@...hat.com" <vkuznets@...hat.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"mchehab+samsung@...nel.org" <mchehab+samsung@...nel.org>,
"davem@...emloft.net" <davem@...emloft.net>,
"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
"arnd@...db.de" <arnd@...db.de>
Subject: Re: [PATCH v4 08/13] arch/x86: Bring few more functions into the
resource structure
Hi Fenghua,
On 10/16/2018 06:45 PM, Fenghua Yu wrote:
> On Mon, Oct 15, 2018 at 08:55:49PM +0000, Moger, Babu wrote:
>> update_mba_bw : Feedback loop bandwidth update functionality is not
>> needed for AMD.
>
> Will you implement update_mba_bw() for AMD in future?
No. There is no plan.
>
>> list_for_each_entry(crgrp, head, mon.crdtgrp_list)
>> mbm_update(d, crgrp->mon.rmid);
>>
>> - if (is_mba_sc(NULL))
>> - update_mba_bw(prgrp, d);
>> + if (is_mba_sc(NULL)) {
>> + r_mba = &rdt_resources_all[RDT_RESOURCE_MBA];
>> + if (r_mba->update_mba_bw)
>> + r_mba->update_mba_bw(prgrp, d);
>> + }
>
> Mount option "mba_MBps" is not implemented on AMD. Then don't
> call set_mba_sc(true) in parse_rdtgroupfs_options().
>
> Thus, you don't need to change this code here because is_mba_sc(NULL) is
> false on AMD.
Yes. is_mba_sc(NULL) is false on AMD. I can remove this change.
>
> Thanks.
>
> -Fenghua
>
Powered by blists - more mailing lists