linux-kernel - Re: [PATCH V9 14/21] csky: User access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a363-ucdqEtrkUah9NPrFtQV6eH=4G3fcQtHMyMStME5w@mail.gmail.com>
Date:   Wed, 17 Oct 2018 17:37:38 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Guo Ren <ren_guo@...ky.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        David Miller <davem@...emloft.net>,
        gregkh <gregkh@...uxfoundation.org>,
        Christoph Hellwig <hch@...radead.org>,
        Marc Zyngier <marc.zyngier@....com>,
        Mark Rutland <mark.rutland@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Rob Herring <robh@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>, c-sky_gcc_upstream@...ky.com
Subject: Re: [PATCH V9 14/21] csky: User access

On Tue, Oct 16, 2018 at 5:05 AM Guo Ren <ren_guo@...ky.com> wrote:
>
> The patch adds "user access from kernel" codes.
>
> Signed-off-by: Guo Ren <ren_guo@...ky.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> ---
>  arch/csky/include/asm/uaccess.h | 416 ++++++++++++++++++++++++++++++++++++++++
>  arch/csky/lib/usercopy.c        | 262 +++++++++++++++++++++++++
>  2 files changed, 678 insertions(+)
>  create mode 100644 arch/csky/include/asm/uaccess.h
>  create mode 100644 arch/csky/lib/usercopy.c

Reviewed-by: Arnd Bergmann <arnd@...db.de>

The 64-bit __put_user() is usually what everyone gets wrong, but
your version seems fine. Also the access_ok() checks and
the copy_to_user() result value all look correct.

        Arnd